nandi/glean · fbad959

nandi/gleanpublic⑂ Fork 0

⑂ fbad959

fix(web): fix auto mark as readUnverified

Julien Robert committed 2026-08-03T12:48:57+02:00 Browse files

fbad959 parent: 54e50b3

modified web/src/routes/articles/[id]/+page.svelte +7 -6 Viewed

@@ -58,17 +58,18 @@
58	58	annotations = data.annotations;
59	59	});
60	60
61		- // Sync local optimistic state when navigating between articles.
62		- $effect(() => {
63		- read = data.article.is_read;
64		- });
	61	+ // Tracks which article id we've already auto-marked read, so the effect
	62	+ // fires once per navigation instead of fighting toggleRead's updates.
	63	+ let markedReadId = $state<number \| null>(null);
65	64
66	65	// Mark the article read on actual navigation. The server's detail handler
67	66	// no longer marks read, so a hover/touch preload won't mark every hovered
68		- // card as read; only a real visit does.
	67	+ // card as read; only a real visit does. Runs once per article, so
	68	+ // toggleRead stays in control of subsequent state changes.
69	69	$effect(() => {
70	70	const id = data.article.id;
71		- if (!read) {
	71	+ if (markedReadId !== id) {
	72	+ markedReadId = id;
72	73	read = true;
73	74	endpoints.markRead(id).catch(() => {
74	75	if (data.article.id === id) read = false;

          annotations = data.annotations;
      });
--    // Sync local optimistic state when navigating between articles.
++    // Tracks which article id we've already auto-marked read, so the effect
--    $effect(() => {
++    // fires once per navigation instead of fighting toggleRead's updates.
--        read = data.article.is_read;
++    let markedReadId = $state<number | null>(null);
--    });
      // Mark the article read on actual navigation. The server's detail handler
      // no longer marks read, so a hover/touch preload won't mark every hovered
--    // card as read; only a real visit does.
++    // card as read; only a real visit does. Runs once per article, so
++    // toggleRead stays in control of subsequent state changes.
      $effect(() => {
          const id = data.article.id;
--        if (!read) {
++        if (markedReadId !== id) {
++            markedReadId = id;
              read = true;
              endpoints.markRead(id).catch(() => {
                  if (data.article.id === id) read = false;