nandi/glean · 54e50b3

nandi/gleanpublic⑂ Fork 0

⑂ 54e50b3

refactor: mark article as read via UI instead of via api callUnverified

Julien Robert committed 2026-08-03T12:40:56+02:00 Browse files

54e50b3 parent: 5bd3cd5

modified internal/server/articles_handler.go +8 -3 Viewed

@@ -152,12 +152,17 @@ func (s Server) handleArticleDetail(w http.ResponseWriter, r http.Request) {
152	152	nextID *int64
153	153	)
154	154
	155	+ var isRead bool
	156	+
155	157	g, gCtx := errgroup.WithContext(ctx)
156	158
157	159	g.Go(func() error {
158		- if err := s.dbs.Articles.MarkArticleRead(gCtx, user.DID, id); err != nil {
159		- s.logger.Warn("failed to mark article read", "error", err, "id", id)
	160	+ state, err := s.dbs.Articles.GetReadState(gCtx, user.DID, id)
	161	+ if err != nil {
	162	+ s.logger.Warn("failed to get read state", "error", err, "id", id)
	163	+ return nil
160	164	}
	165	+ isRead = state.IsRead
161	166	return nil
162	167	})
163	168
@@ -215,7 +220,7 @@ func (s Server) handleArticleDetail(w http.ResponseWriter, r http.Request) {
215	220	_ = g.Wait()
216	221
217	222	dto := toArticle(article)
218		- dto.IsRead = true
	223	+ dto.IsRead = isRead
219	224	dto.LikeCount = likeCount
220	225	dto.HasLiked = liked
221	226

  		nextID      *int64
  	)
++	var isRead bool
++
  	g, gCtx := errgroup.WithContext(ctx)
  	g.Go(func() error {
--		if err := s.dbs.Articles.MarkArticleRead(gCtx, user.DID, id); err != nil {
++		state, err := s.dbs.Articles.GetReadState(gCtx, user.DID, id)
--			s.logger.Warn("failed to mark article read", "error", err, "id", id)
++		if err != nil {
++			s.logger.Warn("failed to get read state", "error", err, "id", id)
++			return nil
  		}
++		isRead = state.IsRead
  		return nil
  	})
  	_ = g.Wait()
  	dto := toArticle(article)
--	dto.IsRead = true
++	dto.IsRead = isRead
  	dto.LikeCount = likeCount
  	dto.HasLiked = liked

modified web/src/routes/articles/[id]/+page.svelte +18 -0 Viewed

@@ -58,6 +58,24 @@
58	58	annotations = data.annotations;
59	59	});
60	60
	61	+ // Sync local optimistic state when navigating between articles.
	62	+ $effect(() => {
	63	+ read = data.article.is_read;
	64	+ });
	65	+
	66	+ // Mark the article read on actual navigation. The server's detail handler
	67	+ // no longer marks read, so a hover/touch preload won't mark every hovered
	68	+ // card as read; only a real visit does.
	69	+ $effect(() => {
	70	+ const id = data.article.id;
	71	+ if (!read) {
	72	+ read = true;
	73	+ endpoints.markRead(id).catch(() => {
	74	+ if (data.article.id === id) read = false;
	75	+ });
	76	+ }
	77	+ });
	78	+
61	79	function clamp(v: number, min: number, max: number) {
62	80	return Math.max(min, Math.min(max, v));
63	81	}

          annotations = data.annotations;
      });
++    // Sync local optimistic state when navigating between articles.
++    $effect(() => {
++        read = data.article.is_read;
++    });
++
++    // Mark the article read on actual navigation. The server's detail handler
++    // no longer marks read, so a hover/touch preload won't mark every hovered
++    // card as read; only a real visit does.
++    $effect(() => {
++        const id = data.article.id;
++        if (!read) {
++            read = true;
++            endpoints.markRead(id).catch(() => {
++                if (data.article.id === id) read = false;
++            });
++        }
++    });
++
      function clamp(v: number, min: number, max: number) {
          return Math.max(min, Math.min(max, v));
      }