Add CHANGELOG entry for secretHash zero fix #8
Merged@julien wants to merge
9-add-changelog-entry into mainMerged as
a62812f692c1.1 file changed
modified
CHANGELOG.md +8 -0 | @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | ||
| 7 | 7 | |
| 8 | 8 | ## [Unreleased] |
| 9 | 9 | |
| 10 | +### Fixed | |
| 11 | + | |
| 12 | +- `Love.deposit(bytes32 secretHash, uint256 wethAmount)` now reverts with | |
| 13 | + `ZeroSecretHash` when called with `secretHash == bytes32(0)`. `claim` uses | |
| 14 | + that same zero value as its "envelope doesn't exist" sentinel, so a | |
| 15 | + zero-hash envelope was previously created successfully but could never be | |
| 16 | + claimed, locking its LOVE permanently. | |
| 17 | + | |
| 10 | 18 | ### Changed |
| 11 | 19 | |
| 12 | 20 | - `Love`'s constructor no longer takes wETH. It reads it from `WETHRegistry` at |
| @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| 7 | 7 | ||
| 8 | ## [Unreleased] | 8 | ## [Unreleased] |
| 9 | 9 | ||
| 10 | +### Fixed | ||
| 11 | + | ||
| 12 | +- `Love.deposit(bytes32 secretHash, uint256 wethAmount)` now reverts with | ||
| 13 | + `ZeroSecretHash` when called with `secretHash == bytes32(0)`. `claim` uses | ||
| 14 | + that same zero value as its "envelope doesn't exist" sentinel, so a | ||
| 15 | + zero-hash envelope was previously created successfully but could never be | ||
| 16 | + claimed, locking its LOVE permanently. | ||
| 17 | + | ||
| 10 | ### Changed | 18 | ### Changed |
| 11 | 19 | ||
| 12 | - `Love`'s constructor no longer takes wETH. It reads it from `WETHRegistry` at | 20 | - `Love`'s constructor no longer takes wETH. It reads it from `WETHRegistry` at |