rickub
julien/lovepublic Fork
⑂ main
Branches
1-add-main-logic 10-fix-weth-chain-allowlist 11-add-changelog-entry 12-add-networks-readme 13-add-supported-networks-doc 14-add-gas-in-love-note 17-add-batch-envelope-deposit 18-replace-envelopes-with-zk 19-add-anvil-e2e-test 2-multichain-check 20-add-mainnet-deployment-docs 21-add-first-op-flow-to-gas-note 3-peg-love-to-weth 5-weth-bytecode-verification 6-add-love-envelope 7-add-docs 8-fix-secrethash-zero 9-add-changelog-entry main View all branches → View all tags →
Commits
⬇ Clone ▾
git clone https://git.rickub.com/julien/love.git
git clone ssh://git@rickub.com/julien/love.git

Host key fingerprint (ed25519): SHA256:iycHnxEyq0Q7uyVpB7JlznP0G7JrTPXLYRcAU5CSLhc — verify it before your first connect.

Download ZIP

Fix secretHash zero overload in claim #7

Merged@julien wants to merge 8-fix-secrethash-zero into main
Merged as 7d97bbb4e340.
  • @julien opened this merge request · Sep 18, 2026

    closes #8

    The privacy deposit(bytes32,uint256) overload accepted any secretHash, including bytes32(0). claim uses secretHash == bytes32(0) as its "does not exist" sentinel, so a zero-hash envelope became permanently unclaimable.

    deposit(bytes32,uint256) now reverts with ZeroSecretHash on a zero hash. Added test_RevertWhen_SecretHashIsZero.

Sign in to comment.