turbo-editors/turbo-go · 2026-08-31-three-themes.md

⑂ 3d7798bf187500c07c52e35cbc80f30990dbd391

2026-08-31-three-themes.md · 33 lines · 2.8 KBmarkdown    Blame HistoryRaw
   1# Handoff — 2026-08-31 — Cappuccino, Cobalt, Monochrome
5Ticket 0012 is implemented and **uncommitted**, on branch `feature/theme-cappucino` (the user created it; HEAD was `9505d1d`). Six themes now ship: the three that existed plus `cappuccino` (espresso brown), `cobalt` (the recognised palette) and `monochrome` (no hue at all).
7No Go code changed. Themes are embedded with `//go:embed themes/*.toml`, so a theme is a file. What did change is the tests: three new ones, and the five that already iterated `theme.Available()` now cover six themes instead of three.
9Full suite green, green under `-race`. Quality gate PASS — 0/0/0, complexity 1592, unchanged. Docs in both languages, `internal/theme/README.md` and the root README in sync.
11Also uncommitted, and **not mine**: `.tickets/issues/0010` at `state: closed`.
13## In flight
17## Next steps
191. **Review and commit.** A commit message was proposed at the end of the session.
202. **Close ticket 0012** — the user's call.
213. Nobody has looked at these three themes on a real screen. The tests hold them to contrast and distinctness, and the VT emulator confirms they render, but *taste* is not testable. Expect to want to nudge a colour or two.
23## Open questions / blockers
27## Watch out for
29- **A blanket readability rule is wrong, and I nearly shipped one.** The faintest colours in every theme — scrollbar trough at 20, desktop, shadow, inactive frame, disabled entry, line-number gutter — are faint *on purpose*. `readKeys` in `internal/editor/view_test.go` lists what must be read and deliberately excludes the furniture. If you add a style key, decide which side it is on; do not add it to `readKeys` reflexively.
30- **The 64 floor is a floor, not a target.** The dimmest reading colour any theme actually uses is 80. Do not raise the constant to "tighten" it — you would be pinning the threshold to today's palettes, and the next legitimate tweak would trip it.
31- **Adding a theme changes the tutorial.** `docs/*/tutorials/getting-started.md` counts arrow presses in the Theme dialog to reach `turbo-dark`, which is last alphabetically. A seventh theme sorting before it makes that count wrong, and a tutorial that miscounts is the one kind of documentation that must never be approximate.
32- **`Defines` is satisfied by inheritance.** That is why `TestEveryEmbeddedThemeParsesAndCoversEveryKey` passed for a theme missing a key, and why `TestEveryEmbeddedThemeSetsEveryKeyItself` exists. It applies to **embedded** themes only — a user theme inheriting is correct and documented.
33- **Falsify a new theme test before trusting it.** All three of these passed the moment they were written, which proves nothing. Each was made to fail on purpose first; the handoffs of this project record more than one test that passed because it tested nothing.

📦 Turbo Go 3d7798b k33g 15h ago	1	# Handoff — 2026-08-31 — Cappuccino, Cobalt, Monochrome
	2
	3	## State
	4
	5	Ticket 0012 is implemented and uncommitted, on branch `feature/theme-cappucino` (the user created it; HEAD was `9505d1d`). Six themes now ship: the three that existed plus `cappuccino` (espresso brown), `cobalt` (the recognised palette) and `monochrome` (no hue at all).
	6
	7	No Go code changed. Themes are embedded with `//go:embed themes/*.toml`, so a theme is a file. What did change is the tests: three new ones, and the five that already iterated `theme.Available()` now cover six themes instead of three.
	8
	9	Full suite green, green under `-race`. Quality gate PASS — 0/0/0, complexity 1592, unchanged. Docs in both languages, `internal/theme/README.md` and the root README in sync.
	10
	11	Also uncommitted, and not mine: `.tickets/issues/0010` at `state: closed`.
	12
	13	## In flight
	14
	15	Nothing.
	16
	17	## Next steps
	18
	19	1. Review and commit. A commit message was proposed at the end of the session.
	20	2. Close ticket 0012 — the user's call.
	21	3. Nobody has looked at these three themes on a real screen. The tests hold them to contrast and distinctness, and the VT emulator confirms they render, but taste is not testable. Expect to want to nudge a colour or two.
	22
	23	## Open questions / blockers
	24
	25	None.
	26
	27	## Watch out for
	28
	29	- A blanket readability rule is wrong, and I nearly shipped one. The faintest colours in every theme — scrollbar trough at 20, desktop, shadow, inactive frame, disabled entry, line-number gutter — are faint on purpose. `readKeys` in `internal/editor/view_test.go` lists what must be read and deliberately excludes the furniture. If you add a style key, decide which side it is on; do not add it to `readKeys` reflexively.
	30	- The 64 floor is a floor, not a target. The dimmest reading colour any theme actually uses is 80. Do not raise the constant to "tighten" it — you would be pinning the threshold to today's palettes, and the next legitimate tweak would trip it.
	31	- Adding a theme changes the tutorial. `docs/*/tutorials/getting-started.md` counts arrow presses in the Theme dialog to reach `turbo-dark`, which is last alphabetically. A seventh theme sorting before it makes that count wrong, and a tutorial that miscounts is the one kind of documentation that must never be approximate.
	32	- `Defines` is satisfied by inheritance. That is why `TestEveryEmbeddedThemeParsesAndCoversEveryKey` passed for a theme missing a key, and why `TestEveryEmbeddedThemeSetsEveryKeyItself` exists. It applies to embedded themes only — a user theme inheriting is correct and documented.
	33	- Falsify a new theme test before trusting it. All three of these passed the moment they were written, which proves nothing. Each was made to fail on purpose first; the handoffs of this project record more than one test that passed because it tested nothing.