nandi/oripublic Fork 0
35061753be581c0ba47a3189520d64e7788c183d
Commits
Clone
git clone https://git.rickub.com/nandi/ori.git
git clone ssh://git@rickub.com/nandi/ori.git

Host key fingerprint (ed25519): SHA256:iycHnxEyq0Q7uyVpB7JlznP0G7JrTPXLYRcAU5CSLhc — verify it before your first connect.

forked from bots-garden/ori

📝 Update project memory after the adapter switch (summary, history, handoff) 4166f8f · on 35061753be581c0ba47a3189520d64e7788c183d · k33g · yesterday
2026-09-18-claude-agent-acp-adapter.md · 27 lines · 2.5 KBmarkdown
Blame HistoryOpen raw

Handoff — 2026-09-18 — ACP adapter switched to @agentclientprotocol/claude-agent-acp

State

Done and merged into main (5d476ff + this memory commit): backend default, template Dockerfile, kit, docs EN+FR, launcher, quality gate PASS (run #18). Published: k33g/ori:0.0.2 (Docker Hub, multi-arch, pushed by the user) and docker.io/k33g/ori-kit:latest (pushed by this session, claude-agent-acp). The user confirmed a real prompt works in sandbox hello-world (template 0.0.2 + published kit, port 5555 dual-stack).

In flight

  • Sandbox hello-world was created with the old kit: its baked startup script still says claude-code-acp; ori was started by hand. On restart it dies again → sbx rm hello-world, recreate with the published kit and -p 5555:8888/tcp. Sandbox ori-acp (local image k33g/ori:0.0.2-local, port 7777) and that template can be removed.
  • amd64 adapter stage: verified in a node:24-bookworm container, not inspected inside the pushed amd64 image (the background buildx --target adapter --platform linux/amd64 was still running when the session moved on).
  • scripts/Launch Ori.app rebuilt from the updated script; still never run end to end.

Next steps

  1. sbx template rm k33g/ori:0.0.2-local, sbx rm ori-acp (housekeeping).
  2. Ticket for an automated real-prompt smoke test (see summary.md "Not yet established").
  3. docs/.assets/ori-architecture.drawio.svg / .json (talk assets) still say claude-code-acp — cosmetic, not updated.

Watch out for

  • npm install --cpu=amd64 installs no native SDK and fails silently; use x64. The Dockerfile asserts the package directory exists.
  • Image and kit must be published together: the kit's --agent-cmd must name the binary the image ships.
  • -p H:8888 = IPv4 only; use /tcp. Chrome blocks 6665–6669.
  • qlty on this Mac: delete dangling .qlty/{logs,out,plugin_cachedir,results} symlinks created inside a sandbox; golangci-lint must be a build with Go ≥ 1.26 (pinned 2.13.2). qlty leaves a stray .shellcheckrc copy at the repo root; safe to delete (identical to .qlty/configs/.shellcheckrc).
  • scripts/launch-ori.applescript came back UTF-16 after a Script Editor save; keep it UTF-8 (iconv -f UTF-16 -t UTF-8).
  • Node 25: run vitest through npm run test (the script carries the webstorage flag); a bare npx vitest run fails 15 tests.
  • A Python edit script that asserts on text must run under && before any git commit: this session's first memory write failed on an anchor and the commit went ahead without it.
 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
# Handoff — 2026-09-18 — ACP adapter switched to @agentclientprotocol/claude-agent-acp

## State

Done and merged into `main` (`5d476ff` + this memory commit): backend default, template Dockerfile, kit, docs EN+FR, launcher, quality gate PASS (run #18). Published: `k33g/ori:0.0.2` (Docker Hub, multi-arch, pushed by the user) and `docker.io/k33g/ori-kit:latest` (pushed by this session, `claude-agent-acp`). The user confirmed a real prompt works in sandbox `hello-world` (template 0.0.2 + published kit, port 5555 dual-stack).

## In flight

- Sandbox `hello-world` was created with the **old** kit: its baked startup script still says `claude-code-acp`; ori was started by hand. On restart it dies again → `sbx rm hello-world`, recreate with the published kit and `-p 5555:8888/tcp`. Sandbox `ori-acp` (local image `k33g/ori:0.0.2-local`, port 7777) and that template can be removed.
- amd64 `adapter` stage: verified in a `node:24-bookworm` container, not inspected inside the pushed amd64 image (the background `buildx --target adapter --platform linux/amd64` was still running when the session moved on).
- `scripts/Launch Ori.app` rebuilt from the updated script; still never run end to end.

## Next steps

1. `sbx template rm k33g/ori:0.0.2-local`, `sbx rm ori-acp` (housekeeping).
2. Ticket for an automated real-prompt smoke test (see `summary.md` "Not yet established").
3. `docs/.assets/ori-architecture.drawio.svg` / `.json` (talk assets) still say `claude-code-acp` — cosmetic, not updated.

## Watch out for

- `npm install --cpu=amd64` installs no native SDK and fails silently; use `x64`. The Dockerfile asserts the package directory exists.
- Image and kit must be published together: the kit's `--agent-cmd` must name the binary the image ships.
- `-p H:8888` = IPv4 only; use `/tcp`. Chrome blocks 6665–6669.
- qlty on this Mac: delete dangling `.qlty/{logs,out,plugin_cachedir,results}` symlinks created inside a sandbox; golangci-lint must be a build with Go ≥ 1.26 (pinned 2.13.2). qlty leaves a stray `.shellcheckrc` copy at the repo root; safe to delete (identical to `.qlty/configs/.shellcheckrc`).
- `scripts/launch-ori.applescript` came back UTF-16 after a Script Editor save; keep it UTF-8 (`iconv -f UTF-16 -t UTF-8`).
- Node 25: run vitest through `npm run test` (the script carries the webstorage flag); a bare `npx vitest run` fails 15 tests.
- A Python edit script that asserts on text must run under `&&` before any `git commit`: this session's first memory write failed on an anchor and the commit went ahead without it.