1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
# A Rust toolchain whose compiler is a dependency rather than a name.
#
# The prelude's system_rust_toolchain hands RustToolchainInfo
# `RunInfo(args = ["rustc"])` — a bare string. Nothing about the compiler is an
# input to any action, so nothing about it reaches the action's cache digest,
# and there is nothing for a remote worker to materialise. Both of this repo's
# problems come from that one line: a shared cache cannot tell two compilers
# apart, and remote execution has no compiler to run.
#
# Here the dist tarball is a dep. cmd_args carries the archive's directory into
# every rustc invocation, so buck knows the action depends on it.
load("@prelude//rust:rust_toolchain.bzl", "PanicRuntime", "RustToolchainInfo")
def _hermetic_rust_toolchain_impl(ctx):
dist = ctx.attrs.dist[DefaultInfo].default_outputs[0]
# The dist tarball keeps its components in sibling directories, so the
# compiler's default sysroot (rustc/) holds no libstd — it lives under
# rust-std-<triple>/. The same stitching scripts/rustc does by hand, said
# to buck instead. The compiler's own codegen libraries are found by rpath,
# relative to the binary, so only the sysroot has to be named.
# rustc goes through a wrapper because the sysroot cannot travel any other
# way: rustc_flags takes plain strings, so an artifact path cannot be put
# there, and putting --sysroot on the compiler unconditionally breaks
# buck's own rustc_cfg action, which passes an empty one. Both the wrapper
# and the tarball are inputs, which is the point.
wrapper = ctx.attrs.wrapper[DefaultInfo].default_outputs[0]
compiler = cmd_args(wrapper, dist, ctx.attrs.rustc_target_triple)
rustdoc = cmd_args(dist, format = "{}/rustc/bin/rustdoc")
return [
DefaultInfo(),
RustToolchainInfo(
allow_lints = ctx.attrs.allow_lints,
clippy_driver = RunInfo(args = cmd_args(dist, format = "{}/clippy/bin/clippy-driver")),
clippy_toml = None,
compiler = RunInfo(args = compiler),
default_edition = ctx.attrs.default_edition,
panic_runtime = PanicRuntime("unwind"),
deny_lints = ctx.attrs.deny_lints,
doctests = ctx.attrs.doctests,
nightly_features = ctx.attrs.nightly_features,
report_unused_deps = ctx.attrs.report_unused_deps,
rustc_binary_flags = ctx.attrs.rustc_binary_flags,
rustc_flags = ctx.attrs.rustc_flags,
rustc_target_triple = ctx.attrs.rustc_target_triple,
rustc_test_flags = ctx.attrs.rustc_test_flags,
rustdoc = RunInfo(args = rustdoc),
rustdoc_flags = ctx.attrs.rustdoc_flags,
warn_lints = ctx.attrs.warn_lints,
),
]
hermetic_rust_toolchain = rule(
impl = _hermetic_rust_toolchain_impl,
attrs = {
"allow_lints": attrs.list(attrs.string(), default = []),
"default_edition": attrs.option(attrs.string(), default = None),
"deny_lints": attrs.list(attrs.string(), default = []),
"dist": attrs.dep(providers = [DefaultInfo]),
"wrapper": attrs.dep(providers = [DefaultInfo]),
"doctests": attrs.bool(default = False),
"nightly_features": attrs.bool(default = True),
"report_unused_deps": attrs.bool(default = False),
"rustc_binary_flags": attrs.list(attrs.arg(), default = []),
"rustc_flags": attrs.list(attrs.arg(), default = []),
"rustc_target_triple": attrs.string(),
"rustc_test_flags": attrs.list(attrs.arg(), default = []),
"rustdoc_flags": attrs.list(attrs.arg(), default = []),
"warn_lints": attrs.list(attrs.string(), default = []),
},
is_toolchain_rule = True,
)
# A C toolchain whose tools are dependencies rather than names.
#
# The prelude's system_cxx_toolchain cannot be made hermetic: it takes its
# tools as plain strings, so nothing it names becomes an input, and it
# hardcodes nm/objcopy/objdump/ranlib/strip as bare PATH lookups regardless of
# what is passed. This is the same construction with zig behind every tool that
# this graph actually runs.
load("@prelude//cxx:cxx_toolchain_types.bzl", "BinaryUtilitiesInfo", "CCompilerInfo", "CxxCompilerInfo", "CxxInternalTools", "CxxPlatformInfo", "CxxToolchainInfo", "DepTrackingMode", "LinkerInfo", "LinkerType", "PicBehavior", "RuntimeDependencyHandling", "ShlibInterfacesMode")
load("@prelude//cxx:headers.bzl", "HeaderMode")
load("@prelude//linking:link_info.bzl", "LinkOrdering", "LinkStyle")
load("@prelude//linking:lto.bzl", "LtoMode")
def _hermetic_cxx_toolchain_impl(ctx: AnalysisContext):
dist = ctx.attrs.dist[DefaultInfo].default_outputs[0]
wrapper = ctx.attrs.wrapper[DefaultInfo].default_outputs[0]
def zig(mode):
return RunInfo(args = cmd_args(wrapper, dist, mode))
cc = zig("cc")
return [
DefaultInfo(),
CxxToolchainInfo(
internal_tools = ctx.attrs.internal_tools[CxxInternalTools],
linker_info = LinkerInfo(
linker = cc,
linker_flags = ["-fuse-ld=lld"] + ctx.attrs.link_flags,
post_linker_flags = [],
archiver = zig("ar"),
archiver_type = "gnu",
archiver_supports_argfiles = True,
generate_linker_maps = False,
lto_mode = LtoMode("none"),
type = LinkerType("gnu"),
link_binaries_locally = True,
link_libraries_locally = True,
archive_objects_locally = True,
use_archiver_flags = True,
static_dep_runtime_ld_flags = [],
static_pic_dep_runtime_ld_flags = [],
shared_dep_runtime_ld_flags = [],
independent_shlib_interface_linker_flags = [],
shlib_interfaces = ShlibInterfacesMode("disabled"),
link_style = LinkStyle(ctx.attrs.link_style),
link_weight = 1,
binary_extension = "",
object_file_extension = "o",
shared_library_name_default_prefix = "lib",
shared_library_name_format = "{}.so",
shared_library_versioned_name_format = "{}.so.{}",
static_library_extension = "a",
force_full_hybrid_if_capable = False,
is_pdb_generated = False,
link_ordering = ctx.attrs.link_ordering,
),
bolt_enabled = False,
# zig carries ar, ranlib and objcopy and nothing else. nm, objdump
# and strip stay bare names: this graph never reaches them — shared
# library interfaces are disabled and nothing is stripped — and a
# build that did would need an llvm dist fetched alongside zig
# rather than a PATH lookup that happens to work.
binary_utilities_info = BinaryUtilitiesInfo(
nm = RunInfo(args = ["nm"]),
objcopy = zig("objcopy"),
objdump = RunInfo(args = ["objdump"]),
ranlib = zig("ranlib"),
strip = RunInfo(args = ["strip"]),
dwp = None,
bolt_msdk = None,
),
cxx_compiler_info = CxxCompilerInfo(
compiler = zig("c++"),
preprocessor_flags = [],
compiler_flags = ctx.attrs.cxx_flags,
compiler_type = "clang",
),
c_compiler_info = CCompilerInfo(
compiler = cc,
preprocessor_flags = [],
compiler_flags = ctx.attrs.c_flags,
compiler_type = "clang",
),
as_compiler_info = CCompilerInfo(
compiler = cc,
compiler_type = "clang",
),
asm_compiler_info = CCompilerInfo(
compiler = cc,
compiler_type = "clang",
),
header_mode = HeaderMode("symlink_tree_only"),
cpp_dep_tracking_mode = DepTrackingMode("show_headers"),
pic_behavior = PicBehavior("supported"),
llvm_link = None,
use_dep_files = True,
runtime_dependency_handling = RuntimeDependencyHandling("no_symlink"),
),
CxxPlatformInfo(name = "x86_64"),
]
hermetic_cxx_toolchain = rule(
impl = _hermetic_cxx_toolchain_impl,
attrs = {
"c_flags": attrs.list(attrs.arg(), default = []),
"cxx_flags": attrs.list(attrs.arg(), default = []),
"dist": attrs.dep(providers = [DefaultInfo]),
"internal_tools": attrs.default_only(attrs.dep(providers = [CxxInternalTools], default = "prelude//cxx/tools:internal_tools")),
"link_flags": attrs.list(attrs.arg(), default = []),
"link_ordering": attrs.option(attrs.enum(LinkOrdering.values()), default = None),
"link_style": attrs.string(default = "shared"),
"wrapper": attrs.dep(providers = [DefaultInfo]),
},
is_toolchain_rule = True,
)
|