rickub
nandi/gleanpublic⑂ Fork 0
⑂ f847c6f
Branches
claude/modal-container-min-76527a main View all branches → View all tags →
Commits
⬇ Clone ▾
git clone https://git.rickub.com/nandi/glean.git
git clone ssh://git@rickub.com/nandi/glean.git

Host key fingerprint (ed25519): SHA256:iycHnxEyq0Q7uyVpB7JlznP0G7JrTPXLYRcAU5CSLhc — verify it before your first connect.

Fix unit testUnverified

Julien Robert committed 2026-04-22T17:25:56+02:00 Browse files
f847c6f parent: 8844048
modified internal/cluster/jaccard_test.go +6 -1
@@ -44,9 +44,10 @@ func seedClusterData(t *testing.T, ctx context.Context, database *db.DB) {
4444 {"https://b.com/feed", "Feed B"},
4545 {"https://c.com/feed", "Feed C"},
4646 {"https://d.com/feed", "Feed D"},
47+ {"https://e.com/feed", "Feed E"},
4748 }
4849 for _, f := range feeds {
49- _, err := database.ExecContext(ctx, `INSERT INTO feeds (feed_url, title, site_url, description, feed_type) VALUES (?, ?, ?, '', 'rss')`, f.url, f.title, f.url)
50+ _, err := database.ExecContext(ctx, `INSERT INTO feeds (feed_url, title, site_url, description, feed_type, subscriber_count) VALUES (?, ?, ?, '', 'rss', 2)`, f.url, f.title, f.url)
5051 assert.NilError(t, err)
5152 }
5253
@@ -54,6 +55,8 @@ func seedClusterData(t *testing.T, ctx context.Context, database *db.DB) {
5455 {"did:test:alice", "https://a.com/feed"},
5556 {"did:test:alice", "https://b.com/feed"},
5657 {"did:test:alice", "https://c.com/feed"},
58+ {"did:test:alice", "https://d.com/feed"},
59+ {"did:test:alice", "https://e.com/feed"},
5760 {"did:test:bob", "https://a.com/feed"},
5861 {"did:test:bob", "https://b.com/feed"},
5962 {"did:test:bob", "https://d.com/feed"},
@@ -424,8 +427,10 @@ func TestColdStartRecommendations_NotTriggeredForEstablishedUser(t *testing.T) {
424427 ctx := context.Background()
425428 database := setupClusterTestDB(t)
426429 seedClusterData(t, ctx, database)
430+ seedFollowData(t, ctx, database)
427431
428432 engine := NewEngine(database.DB, slog.Default())
433+ assert.NilError(t, engine.ComputeFollowDistances(ctx))
429434
430435 recs, err := engine.ColdStartRecommendations(ctx, "did:test:alice", 10)
431436 assert.NilError(t, err)
@@ -44,9 +44,10 @@ func seedClusterData(t *testing.T, ctx context.Context, database *db.DB) {
44 {"https://b.com/feed", "Feed B"},44 {"https://b.com/feed", "Feed B"},
45 {"https://c.com/feed", "Feed C"},45 {"https://c.com/feed", "Feed C"},
46 {"https://d.com/feed", "Feed D"},46 {"https://d.com/feed", "Feed D"},
47+ {"https://e.com/feed", "Feed E"},
47 }48 }
48 for _, f := range feeds {49 for _, f := range feeds {
49- _, err := database.ExecContext(ctx, `INSERT INTO feeds (feed_url, title, site_url, description, feed_type) VALUES (?, ?, ?, '', 'rss')`, f.url, f.title, f.url)50+ _, err := database.ExecContext(ctx, `INSERT INTO feeds (feed_url, title, site_url, description, feed_type, subscriber_count) VALUES (?, ?, ?, '', 'rss', 2)`, f.url, f.title, f.url)
50 assert.NilError(t, err)51 assert.NilError(t, err)
51 }52 }
52 53
@@ -54,6 +55,8 @@ func seedClusterData(t *testing.T, ctx context.Context, database *db.DB) {
54 {"did:test:alice", "https://a.com/feed"},55 {"did:test:alice", "https://a.com/feed"},
55 {"did:test:alice", "https://b.com/feed"},56 {"did:test:alice", "https://b.com/feed"},
56 {"did:test:alice", "https://c.com/feed"},57 {"did:test:alice", "https://c.com/feed"},
58+ {"did:test:alice", "https://d.com/feed"},
59+ {"did:test:alice", "https://e.com/feed"},
57 {"did:test:bob", "https://a.com/feed"},60 {"did:test:bob", "https://a.com/feed"},
58 {"did:test:bob", "https://b.com/feed"},61 {"did:test:bob", "https://b.com/feed"},
59 {"did:test:bob", "https://d.com/feed"},62 {"did:test:bob", "https://d.com/feed"},
@@ -424,8 +427,10 @@ func TestColdStartRecommendations_NotTriggeredForEstablishedUser(t *testing.T) {
424 ctx := context.Background()427 ctx := context.Background()
425 database := setupClusterTestDB(t)428 database := setupClusterTestDB(t)
426 seedClusterData(t, ctx, database)429 seedClusterData(t, ctx, database)
430+ seedFollowData(t, ctx, database)
427 431
428 engine := NewEngine(database.DB, slog.Default())432 engine := NewEngine(database.DB, slog.Default())
433+ assert.NilError(t, engine.ComputeFollowDistances(ctx))
429 434
430 recs, err := engine.ColdStartRecommendations(ctx, "did:test:alice", 10)435 recs, err := engine.ColdStartRecommendations(ctx, "did:test:alice", 10)
431 assert.NilError(t, err)436 assert.NilError(t, err)