nandi/glean · 59d6bbb

nandi/gleanpublic⑂ Fork 0

⑂ 59d6bbb

Increase people recommendation diversityUnverified

Julien Robert committed 2026-04-29T13:29:13+02:00 Browse files

59d6bbb parent: be4aec4

modified internal/cluster/scoring.go +22 -3 Viewed

@@ -68,13 +68,32 @@ func (e *Engine) GetFeedRecommendations(ctx context.Context, userDID string, lim
68	68	}
69	69
70	70	// GetPeopleRecommendations returns similar users based on subscription overlap,
71		-// like co-occurrence, tag overlap, and follow relationships. Scores are min-max
72		-// normalized on the Jaccard field.
	71	+// like co-occurrence, tag overlap, and follow relationships. Up to half the
	72	+// limit come from the user's network (followed) and half from outside. When
	73	+// outside-network candidates are scarce, in-network fills the remaining slots.
73	74	func (e Engine) GetPeopleRecommendations(ctx context.Context, userDID string, limit int) ([]PersonRecommendation, error) {
74		- recs, err := e.ComputePeopleRecommendationsOnDemand(ctx, userDID, limit)
	75	+ recs, err := e.ComputePeopleRecommendationsOnDemand(ctx, userDID, limit*2)
75	76	if err != nil {
76	77	return nil, err
77	78	}
	79	+
	80	+ half := max(limit/2, 1)
	81	+
	82	+ var inNet, outNet []*PersonRecommendation
	83	+ for _, r := range recs {
	84	+ if r.IsFollowed {
	85	+ inNet = append(inNet, r)
	86	+ } else {
	87	+ outNet = append(outNet, r)
	88	+ }
	89	+ }
	90	+
	91	+ outTake := min(half, len(outNet))
	92	+ inTake := min(limit-outTake, len(inNet))
	93	+ recs = recs[:0]
	94	+ recs = append(recs, inNet[:inTake]...)
	95	+ recs = append(recs, outNet[:outTake]...)
	96	+
78	97	normalizePersonScores(recs)
79	98	return recs, nil
80	99	}

  }
  // GetPeopleRecommendations returns similar users based on subscription overlap,
--// like co-occurrence, tag overlap, and follow relationships. Scores are min-max
++// like co-occurrence, tag overlap, and follow relationships. Up to half the
--// normalized on the Jaccard field.
++// limit come from the user's network (followed) and half from outside. When
++// outside-network candidates are scarce, in-network fills the remaining slots.
  func (e *Engine) GetPeopleRecommendations(ctx context.Context, userDID string, limit int) ([]*PersonRecommendation, error) {
--	recs, err := e.ComputePeopleRecommendationsOnDemand(ctx, userDID, limit)
++	recs, err := e.ComputePeopleRecommendationsOnDemand(ctx, userDID, limit*2)
  	if err != nil {
  		return nil, err
  	}
++
++	half := max(limit/2, 1)
++
++	var inNet, outNet []*PersonRecommendation
++	for _, r := range recs {
++		if r.IsFollowed {
++			inNet = append(inNet, r)
++		} else {
++			outNet = append(outNet, r)
++		}
++	}
++
++	outTake := min(half, len(outNet))
++	inTake := min(limit-outTake, len(inNet))
++	recs = recs[:0]
++	recs = append(recs, inNet[:inTake]...)
++	recs = append(recs, outNet[:outTake]...)
++
  	normalizePersonScores(recs)
  	return recs, nil
  }