rickub
nandi/gleanpublic⑂ Fork 0
⑂ 2976683
Branches
claude/modal-container-min-76527a main View all branches → View all tags →
Commits
⬇ Clone ▾
git clone https://git.rickub.com/nandi/glean.git
git clone ssh://git@rickub.com/nandi/glean.git

Host key fingerprint (ed25519): SHA256:iycHnxEyq0Q7uyVpB7JlznP0G7JrTPXLYRcAU5CSLhc — verify it before your first connect.

Use request context instead of background for goroutinesUnverified

Julien Robert committed 2026-05-06T09:42:44+02:00 Browse files
2976683 parent: d5f9944
modified internal/server/feeds_handler.go +2 -2
@@ -186,7 +186,7 @@ func (s *Server) handleAddFeed(w http.ResponseWriter, r *http.Request) {
186186 return
187187 }
188188
189- go s.storeFetchResult(context.Background(), feedURL, result.Feed.SiteURL, result)
189+ go s.storeFetchResult(context.WithoutCancel(r.Context()), feedURL, result.Feed.SiteURL, result)
190190
191191 if err := s.engine.MarkImpressionActed(r.Context(), user.DID, "feed", feedURL); err != nil {
192192 s.logger.Warn("failed to mark impression acted", "error", err)
@@ -335,7 +335,7 @@ func (s *Server) handleOPMLUpload(w http.ResponseWriter, r *http.Request) {
335335 }
336336
337337 go func() {
338- g, ctx := errgroup.WithContext(context.Background())
338+ g, ctx := errgroup.WithContext(context.WithoutCancel(r.Context()))
339339 g.SetLimit(5)
340340 for _, f := range feedsToFetch {
341341 g.Go(func() error {
@@ -186,7 +186,7 @@ func (s *Server) handleAddFeed(w http.ResponseWriter, r *http.Request) {
186 return186 return
187 }187 }
188 188
189- go s.storeFetchResult(context.Background(), feedURL, result.Feed.SiteURL, result)189+ go s.storeFetchResult(context.WithoutCancel(r.Context()), feedURL, result.Feed.SiteURL, result)
190 190
191 if err := s.engine.MarkImpressionActed(r.Context(), user.DID, "feed", feedURL); err != nil {191 if err := s.engine.MarkImpressionActed(r.Context(), user.DID, "feed", feedURL); err != nil {
192 s.logger.Warn("failed to mark impression acted", "error", err)192 s.logger.Warn("failed to mark impression acted", "error", err)
@@ -335,7 +335,7 @@ func (s *Server) handleOPMLUpload(w http.ResponseWriter, r *http.Request) {
335 }335 }
336 336
337 go func() {337 go func() {
338- g, ctx := errgroup.WithContext(context.Background())338+ g, ctx := errgroup.WithContext(context.WithoutCancel(r.Context()))
339 g.SetLimit(5)339 g.SetLimit(5)
340 for _, f := range feedsToFetch {340 for _, f := range feedsToFetch {
341 g.Go(func() error {341 g.Go(func() error {