nandi/glean · 116dd3b

nandi/gleanpublic⑂ Fork 0

⑂ 116dd3b

Add cache invalidation for feed, article, and peopleUnverified

Julien Robert committed 2026-05-15T13:20:48+02:00 Browse files

116dd3b parent: c1916a6

modified internal/cluster/scoring.go +12 -0 Viewed

@@ -47,6 +47,18 @@ type ArticleRecommendation struct {
47	47	Score float64
48	48	}
49	49
	50	+func (e *Engine) InvalidateFeedCache(userDID string) {
	51	+ e.feedCache.Remove(userDID)
	52	+}
	53	+
	54	+func (e *Engine) InvalidateArticleCache(userDID string) {
	55	+ e.articleCache.Remove(userDID)
	56	+}
	57	+
	58	+func (e *Engine) InvalidatePeopleCache(userDID string) {
	59	+ e.peopleCache.Remove(userDID)
	60	+}
	61	+
50	62	// GetFeedRecommendations returns feed recommendations for a user. Users with
51	63	// fewer than 5 subscriptions get cold-start recommendations (embedding-based
52	64	// KNN or graph+popular fallback). Results are min-max normalized and

  	Score      float64
  }
++func (e *Engine) InvalidateFeedCache(userDID string) {
++	e.feedCache.Remove(userDID)
++}
++
++func (e *Engine) InvalidateArticleCache(userDID string) {
++	e.articleCache.Remove(userDID)
++}
++
++func (e *Engine) InvalidatePeopleCache(userDID string) {
++	e.peopleCache.Remove(userDID)
++}
++
  // GetFeedRecommendations returns feed recommendations for a user. Users with
  // fewer than 5 subscriptions get cold-start recommendations (embedding-based
  // KNN or graph+popular fallback). Results are min-max normalized and

modified internal/server/recs_handler.go +6 -4 Viewed

@@ -5,18 +5,18 @@ import (
5	5	)
6	6
7	7	func (s Server) handleDismissFeedRecommendation(w http.ResponseWriter, r http.Request) {
8		- s.handleDismiss(w, r, "feed_url", "feed")
	8	+ s.handleDismiss(w, r, "feed_url", "feed", func(did string) { s.engine.InvalidateFeedCache(did) })
9	9	}
10	10
11	11	func (s Server) handleDismissArticleRecommendation(w http.ResponseWriter, r http.Request) {
12		- s.handleDismiss(w, r, "article_url", "article")
	12	+ s.handleDismiss(w, r, "article_url", "article", func(did string) { s.engine.InvalidateArticleCache(did) })
13	13	}
14	14
15	15	func (s Server) handleDismissPersonRecommendation(w http.ResponseWriter, r http.Request) {
16		- s.handleDismiss(w, r, "target_did", "person")
	16	+ s.handleDismiss(w, r, "target_did", "person", func(did string) { s.engine.InvalidatePeopleCache(did) })
17	17	}
18	18
19		-func (s Server) handleDismiss(w http.ResponseWriter, r http.Request, field, targetType string) {
	19	+func (s Server) handleDismiss(w http.ResponseWriter, r http.Request, field, targetType string, invalidateCache func(string)) {
20	20	user := currentUser(r)
21	21	targetID := r.FormValue(field)
22	22	if targetID == "" {
@@ -35,5 +35,7 @@ func (s Server) handleDismiss(w http.ResponseWriter, r http.Request, field, ta
35	35	return
36	36	}
37	37
	38	+ invalidateCache(user.DID)
	39	+
38	40	w.WriteHeader(http.StatusOK)
39	41	}

  )
  func (s *Server) handleDismissFeedRecommendation(w http.ResponseWriter, r *http.Request) {
--	s.handleDismiss(w, r, "feed_url", "feed")
++	s.handleDismiss(w, r, "feed_url", "feed", func(did string) { s.engine.InvalidateFeedCache(did) })
  }
  func (s *Server) handleDismissArticleRecommendation(w http.ResponseWriter, r *http.Request) {
--	s.handleDismiss(w, r, "article_url", "article")
++	s.handleDismiss(w, r, "article_url", "article", func(did string) { s.engine.InvalidateArticleCache(did) })
  }
  func (s *Server) handleDismissPersonRecommendation(w http.ResponseWriter, r *http.Request) {
--	s.handleDismiss(w, r, "target_did", "person")
++	s.handleDismiss(w, r, "target_did", "person", func(did string) { s.engine.InvalidatePeopleCache(did) })
  }
--func (s *Server) handleDismiss(w http.ResponseWriter, r *http.Request, field, targetType string) {
++func (s *Server) handleDismiss(w http.ResponseWriter, r *http.Request, field, targetType string, invalidateCache func(string)) {
  	user := currentUser(r)
  	targetID := r.FormValue(field)
  	if targetID == "" {
  		return
  	}
++	invalidateCache(user.DID)
++
  	w.WriteHeader(http.StatusOK)
  }