nandi/frq · e04bb83

nandi/frqpublic⑂ Fork 0

⑂ e04bb83

The caret goes after the word, not around it

Tab completion came back highlighted: `nandi.uk: ` arrived selected, and the
next character typed would have replaced the name it had just finished.

`controller-for` was assigning `.text`, which leaves the selection at offset
-1 — and Flutter draws that as the whole field selected. The whole
`TextEditingValue` goes in now, with the caret collapsed after the last
character.

Every programmatic write to an entry gets it, not only Tab: a nick restored
from a saved session, a handle landing after sign-in. None of them wanted the
field selected either; the completion is just the one that made it obvious.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

nandi committed 2026-09-17T19:49:40-07:00 Browse files

e04bb83 parent: 8c38fb8

modified flutter/src/frq/hiccup.cljd +13 -4 Viewed

@@ -155,11 +155,20 @@
155	155	(let [c (m/TextEditingController .text (or text ""))]
156	156	(swap! controllers assoc k c)
157	157	c))]
158		- ;; Only when it differs, and never while it would move the caret: the cell
159		- ;; is the authority for what the entry says, but the person typing is the
160		- ;; authority for where they are in it.
	158	+ ;; Only when it differs: the cell is the authority for what the entry
	159	+ ;; says, but the person typing is the authority for where they are in it,
	160	+ ;; and every keystroke would otherwise be written back over itself.
	161	+ ;;
	162	+ ;; The whole value and not just `.text`, which is the bug Tab completion
	163	+ ;; found. Assigning `.text` leaves the selection at offset -1, and Flutter
	164	+ ;; draws that as the entire field selected — so completing a nick handed
	165	+ ;; back `nandi.uk: ` highlighted, and the next character typed would have
	166	+ ;; replaced it. The caret belongs after what was just put there.
161	167	(when (and text (not= text (.-text c)))
162		- (set! (.-text c) text))
	168	+ (set! (.-value c)
	169	+ (m/TextEditingValue
	170	+ .text text
	171	+ .selection (m/TextSelection.collapsed .offset (count text)))))
163	172	c))
164	173
165	174	;; ------------------------------------------------------------------ props

                (let [c (m/TextEditingController .text (or text ""))]
                  (swap! controllers assoc k c)
                  c))]
--    ;; Only when it differs, and never while it would move the caret: the cell
++    ;; Only when it differs: the cell is the authority for what the entry
--    ;; is the authority for what the entry says, but the person typing is the
++    ;; says, but the person typing is the authority for where they are in it,
--    ;; authority for where they are in it.
++    ;; and every keystroke would otherwise be written back over itself.
++    ;;
++    ;; The whole value and not just `.text`, which is the bug Tab completion
++    ;; found. Assigning `.text` leaves the selection at offset -1, and Flutter
++    ;; draws that as the entire field selected — so completing a nick handed
++    ;; back `nandi.uk: ` highlighted, and the next character typed would have
++    ;; replaced it. The caret belongs after what was just put there.
      (when (and text (not= text (.-text c)))
--      (set! (.-text c) text))
++      (set! (.-value c)
++            (m/TextEditingValue
++             .text text
++             .selection (m/TextSelection.collapsed .offset (count text)))))
      c))
  ;; ------------------------------------------------------------------ props