nandi/frq · 7f86322

nandi/frqpublic⑂ Fork 0

⑂ 7f86322

Let the two bottom-pinned screens have the window

The chats list and the conversation each pin something to the bottom — the
tab bar, the compose bar — and each marks the band above it :fill-height so
the scroll in it takes the rest. Neither said anything about its own root,
which under jvui is as tall as what is in it: the band asks for the rest of
the screen, is told the rest is what the backlog already occupies, and the
whole screen paints into a strip along the top with the window empty below
it. The split view already said :fill-height, one wrapper further out, which
is why only the narrow layouts showed this.

:reserve moves onto the :scroll from the column around it. It only ever
meant "leave this much of the height behind", and the viewport is what has
to be told: a column does not read it, so the scroll took everything down
to the bottom edge and the strip below went off the window until the layout
settled. The numbers are unchanged — below-list and below-messages count
what follows, and what follows the column is what follows the scroll in it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

nandi committed 2026-09-10T09:48:55-07:00 Browse files

7f86322 parent: 468684e

modified src/frq/app.clj +16 -5 Viewed

@@ -297,7 +297,14 @@
297	297	;; What goes with the page is its centring at 620, on a window between that
298	298	;; and the split view's 900: the list is full-bleed there now, which is
299	299	;; what the conversation beside it has always been.
300		- [:vbox {:spacing 8 :margin 12}
	300	+ ;; `:fill-height` on the outermost box, not only on the band inside it.
	301	+ ;; A backend that gives a column the height of what is in it hands the
	302	+ ;; band below a window's worth of nothing to divide: the list asks for
	303	+ ;; the rest of the screen, is told the rest is forty points, and the
	304	+ ;; whole screen paints into a strip along the top with the window empty
	305	+ ;; under it. Every screen that pins something to the bottom says this on
	306	+ ;; its own root — the split view already said it, one wrapper further out.
	307	+ [:vbox {:spacing 8 :margin 12 :fill-height true}
301	308	[:vbox {:key :head :spacing 8}
302	309	;; Your nick in the title, where "Chats" alone said nothing you did not
303	310	;; already know. It is what every channel calls you and what your own
@@ -345,8 +352,9 @@
345	352	;; the tabs' strip out of what it may take.
346	353	;; Named, so it is the same list — and the same scroll position — when the
347	354	;; reader comes back from a conversation.
348		- [:vbox {:key :list :fill-height true :reserve (below-list)}
349		- [:scroll {:scroll-key "chats-list" :orientation :vertical}
	355	+ [:vbox {:key :list :fill-height true}
	356	+ [:scroll {:scroll-key "chats-list" :orientation :vertical
	357	+ :reserve (below-list)}
350	358	(if (seq buffers)
351	359	;; Keyed on the name, because this list reorders: opening a
352	360	;; conversation bumps it to the top, and unkeyed children reconcile by
@@ -1309,7 +1317,10 @@
1309	1317	;; plain End for its own caret and leaves this one alone — so it arrives
1310	1318	;; here by bubbling up from whatever had the focus. The window backend
1311	1319	;; registers the handler and never calls it: keys there belong to egui.
1312		- [:vbox {:spacing 8 :margin 12
	1320	+ ;; `:fill-height` for the reason the chats screen gives on its own root:
	1321	+ ;; without it this column is as tall as what is in it, and the compose bar
	1322	+ ;; sits wherever the backlog happens to end rather than at the bottom.
	1323	+ [:vbox {:spacing 8 :margin 12 :fill-height true
1313	1324	:on-key (fn [k]
1314	1325	(when (= k "ctrl+end") (s/jump-to-present!)))}
1315	1326	[:hbox {:spacing 8}
@@ -1361,10 +1372,10 @@
1361	1372	;; it every time the panel was toggled.
1362	1373	[:hbox {:spacing 8 :wrap false}
1363	1374	[:vbox {:key :messages :fill-height true
1364		- :reserve (below-messages)
1365	1375	:width-request (if show-users? (messages-width) 0)}
1366	1376	[:scroll {:scroll-key (messages-scroll-key)
1367	1377	:orientation :vertical
	1378	+ :reserve (below-messages)
1368	1379	:stick-to-bottom true
1369	1380	:scroll-to-bottom @s/jump-tick
1370	1381	:on-change #(reset! s/at-present? (= "end" %))

      ;; What goes with the page is its centring at 620, on a window between that
      ;; and the split view's 900: the list is full-bleed there now, which is
      ;; what the conversation beside it has always been.
--    [:vbox {:spacing 8 :margin 12}
++    ;; `:fill-height` on the outermost box, not only on the band inside it.
++    ;; A backend that gives a column the height of what is in it hands the
++    ;; band below a window's worth of nothing to divide: the list asks for
++    ;; the rest of the screen, is told the rest is forty points, and the
++    ;; whole screen paints into a strip along the top with the window empty
++    ;; under it. Every screen that pins something to the bottom says this on
++    ;; its own root — the split view already said it, one wrapper further out.
++    [:vbox {:spacing 8 :margin 12 :fill-height true}
       [:vbox {:key :head :spacing 8}
         ;; Your nick in the title, where "Chats" alone said nothing you did not
        ;; already know. It is what every channel calls you and what your own
       ;; the tabs' strip out of what it may take.
       ;; Named, so it is the same list — and the same scroll position — when the
       ;; reader comes back from a conversation.
--     [:vbox {:key :list :fill-height true :reserve (below-list)}
++     [:vbox {:key :list :fill-height true}
--      [:scroll {:scroll-key "chats-list" :orientation :vertical}
++      [:scroll {:scroll-key "chats-list" :orientation :vertical
++                :reserve (below-list)}
         (if (seq buffers)
           ;; Keyed on the name, because this list reorders: opening a
           ;; conversation bumps it to the top, and unkeyed children reconcile by
      ;; plain End for its own caret and leaves this one alone — so it arrives
      ;; here by bubbling up from whatever had the focus. The window backend
      ;; registers the handler and never calls it: keys there belong to egui.
--    [:vbox {:spacing 8 :margin 12
++    ;; `:fill-height` for the reason the chats screen gives on its own root:
++    ;; without it this column is as tall as what is in it, and the compose bar
++    ;; sits wherever the backlog happens to end rather than at the bottom.
++    [:vbox {:spacing 8 :margin 12 :fill-height true
              :on-key (fn [k]
                        (when (= k "ctrl+end") (s/jump-to-present!)))}
       [:hbox {:spacing 8}
       ;; it every time the panel was toggled.
       [:hbox {:spacing 8 :wrap false}
        [:vbox {:key :messages :fill-height true
--              :reserve (below-messages)
                :width-request (if show-users? (messages-width) 0)}
         [:scroll {:scroll-key (messages-scroll-key)
                   :orientation :vertical
++                 :reserve (below-messages)
                   :stick-to-bottom true
                   :scroll-to-bottom @s/jump-tick
                   :on-change #(reset! s/at-present? (= "end" %))